-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
Please change the content in the PanicGuide with some relevant information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Dockerfile does not look OK.
The service is not released to dev and therefore not tested if it works.
Let's also add a "__build-info" endpoint. I think we should add the following line after line 96 in "synth-publish.go"
http.HandleFunc(httphandlers.BuildInfoPath, httphandlers.BuildInfoHandler)
03a3a5a
to
2ce14ba
Compare
We can also add a badge for the go report card |
@gkazakov111 with the current Docker file the |
e6a6768
to
5ace2a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the commits before merging.
94f817e
to
b8829b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
synthetic-image-publication-monitor-6b486d58b7-rts7v synthetic-image-publication-monitor 2020/05/15 13:40:58 cmdR.Run() failed with exec: "kubectl": executable file not found in $PATH
b8829b2
to
5a4fc6d
Compare
Seems to be OK now, however I'd recommend to watch for some time to see if the |
5a4fc6d
to
7762477
Compare
No description provided.