Updated model and removed author service #35
Conversation
service/es_model_populator.go
Outdated
| default: | ||
| return esModel, nil | ||
| } | ||
| } | ||
|
|
||
| func (mp *EsModelPopulator) ConvertAggregateConceptToESConceptModel(concept AggregateConceptModel, conceptType string, publishRef string) (interface{}, error) { | ||
| func ConvertAggregateConceptToESConceptModel(concept AggregateConceptModel, conceptType string, publishRef string) (interface{}, error) { | ||
| esModel := convertAggregateConceptToESConceptModel(concept, conceptType, publishRef) |
There was a problem hiding this comment.
Similar comment to above... I think that you can get rid of this function just by using the code at line 55.
service/es_model_populator.go
Outdated
| } | ||
|
|
||
| func (mp *EsModelPopulator) ConvertConceptToESConceptModel(concept ConceptModel, conceptType string, publishRef string) (interface{}, error) { | ||
| func ConvertConceptToESConceptModel(concept ConceptModel, conceptType string, publishRef string) (interface{}, error) { | ||
| esModel := convertToESConceptModel(concept, conceptType, publishRef) |
There was a problem hiding this comment.
Something really minor. I think that you can get rid of this function just by using the code at line 59. In my opinion, convertToESConceptModel has confusing name and it is useless since it is implemented by a single line of code.
service/es_model_populator.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| isFTAuthor := strconv.FormatBool(concept.IsAuthor) | ||
| if isFTAuthor == "" { |
There was a problem hiding this comment.
Since strconv.FormatBool returns only "true" or "false" strings, this condition is never true. So, this if statement is not necessary anymore.
service/es_model_populator.go
Outdated
| } | ||
| return *person, nil | ||
| return *esPersonModel, nil |
There was a problem hiding this comment.
Same comment as above about pointers
service/es_model_populator.go
Outdated
| } | ||
| return *person, nil | ||
| return *esPersonModel, nil |
There was a problem hiding this comment.
I am a bit confused... esPersonModel is returned as a pointer to a pointer of EsPersonConceptModel (because you used & at line 25 and * at line 29) and esModel is returned as copy... I have the impression that you can simply return both variables as a copy.
No description provided.