Feature/vendoring #8
Conversation
- Ignore all files in /vendor other than vendor.json - Back off elasticsearch client to match the version in concept-search-api - Add govendor to circle.yml
| "ignore": "test", | ||
| "package": [ | ||
| { | ||
| "checksumSHA1": "4gy/7n/lgtdi5efuHXwFcIe1ZI8=", |
There was a problem hiding this comment.
Few libraries that you use are versioned. (I created a version for most FT libraries)
I think it is more clear to point to a specific version tag rather than latest commit in the master branch.
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=========================================
Coverage ? 35.98%
=========================================
Files ? 8
Lines ? 339
Branches ? 0
=========================================
Hits ? 122
Misses ? 212
Partials ? 5Continue to review full report at Codecov.
|
vendor/vendor.json
Outdated
| }, | ||
| { | ||
| "checksumSHA1": "ziYrpyU5zo1q9+n1kaXqkR3kP2s=", | ||
| "path": "github.com/stretchr/testify/assert", |
There was a problem hiding this comment.
It looks like that latest version for github.com/stretchr/testify/assert is 1.1.4, but if you are using some features that are implemented only in the master branch, it looks good to me.
Tests still pass with this version, so we aren't relying on any later features. I had to match the nested vendoring revision manually, and govendor doesn't use the "version" property for those resources.
No description provided.