Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate helm #7

Merged
merged 10 commits into from
Sep 4, 2017
Merged

Integrate helm #7

merged 10 commits into from
Sep 4, 2017

Conversation

MMoisa
Copy link
Contributor

@MMoisa MMoisa commented Jul 26, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-30.3%) to 53.818% when pulling a5f720a on feature/helm-integration into c7252b9 on master.

@MMoisa MMoisa mentioned this pull request Jul 26, 2017
Merged
@coveralls
Copy link

Coverage Status

Coverage decreased (-30.3%) to 53.818% when pulling 76a8c79 on feature/helm-integration into c7252b9 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-30.3%) to 53.818% when pulling e8c3f03 on feature/helm-integration into c7252b9 on master.

tosan88
tosan88 reviewed Sep 1, 2017
View reviewed changes
helm/content-collection-rw-neo4j/app-configs/content-collection-rw-neo4j_delivery.yaml
replicaCount: 1
service:
name: content-collection-rw-neo4j
env:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to define these env vars in the deafault yml file with empty values

tosan88
tosan88 reviewed Sep 1, 2017
View reviewed changes
helm/content-collection-rw-neo4j/app-configs/content-collection-rw-neo4j_delivery.yaml Outdated
APP_NAME: "Content Collection RW Neo4j"
LOG_METRICS: "false"
CACHE_DURATION: "30s"
GRAPHITE_PREFIX: "coco.services.k8s.content-collection-rw-neo4j"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The env should be parameterized, like here https://github.com/Financial-Times/api-policy-component/pull/7/files#diff-866c4c8df732bf3669bced5129efb570R45

@tosan88 tosan88 self-assigned this Sep 1, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-30.3%) to 53.818% when pulling 985fa9b on feature/helm-integration into c7252b9 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-30.3%) to 53.818% when pulling ee7f4c8 on feature/helm-integration into c7252b9 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-30.3%) to 53.818% when pulling becdd45 on feature/helm-integration into c7252b9 on master.

@tosan88 tosan88 merged commit c22cea9 into master Sep 4, 2017
@tamas-molnar tamas-molnar deleted the feature/helm-integration branch May 8, 2018 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tosan88 tosan88 tosan88 approved these changes

Assignees

@tosan88 tosan88

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MMoisa @coveralls @tosan88