This repository has been archived by the owner on Jan 11, 2021. It is now read-only.
Uppsf 143 improvements #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epavlova
suggested changes
Feb 19, 2019
Gopkg.toml
Outdated
| @@ -0,0 +1,62 @@ | |||
| # Gopkg.toml example | |||
There was a problem hiding this comment.
Please remove the example toml file (the comments in this file)
main_test.go
Outdated
| @@ -19,6 +13,11 @@ import ( | |||
| "github.com/Financial-Times/transactionid-utils-go" | |||
| "github.com/gorilla/mux" | |||
| "github.com/stretchr/testify/assert" | |||
| "io/ioutil" | |||
There was a problem hiding this comment.
You can use goimports linter to make sure that the imports are in the following order:
- imports from the Go standard library in alphabetical order;
- external imports in alphabetical order;
Every go code file follows these rules.
epavlova
approved these changes
Feb 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated go version, logger and switching from govendor go dep.