Skip to content
This repository has been archived by the owner on Jan 11, 2021. It is now read-only.

Add runbook #27

Merged
merged 1 commit into from Aug 12, 2020
Merged

Add runbook #27

merged 1 commit into from Aug 12, 2020

Conversation

mchompalova
Copy link
Contributor

@mchompalova mchompalova commented Aug 12, 2020

Description

What

Add runbook for the service.

Why

https://financialtimes.atlassian.net/browse/UPPSF-1181

Scope and particulars of this PR (Please tick all that apply)

  • Tech hygiene (dependency updating & other tech debt)
  • Bug fix
  • Feature
  • Documentation
  • Breaking change
  • Minor change (e.g. fixing a typo, adding config)

This Pull Request follows the rules described in our Pull Requests Guide

@mchompalova mchompalova requested review from ekaneva and a team August 12, 2020 07:16
@coveralls
Copy link

coveralls commented Aug 12, 2020

Coverage Status

Coverage remained the same at 78.78% when pulling 169519c on fix/UPPSF-1181-add-runbook into f2541be on master.

.github/runbooks.yml Outdated Show resolved Hide resolved
runbooks/runbook.md Outdated Show resolved Hide resolved
runbooks/runbook.md Outdated Show resolved Hide resolved
Copy link

@ekaneva ekaneva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something that I notice just now is that we mix the unordered list items notation (- with *).

It is like so for many (if not for all) prior runbooks, but since it does not matter for the runbook validator, we can live with this havoc. :D

Maybe just for future runbooks, it will be a good idea to match their style. Per our Markdown guide, the -es are the preferred notation.

@ekaneva ekaneva requested a review from a team August 12, 2020 08:37
@mchompalova mchompalova merged commit 4c59ce8 into master Aug 12, 2020
@mchompalova mchompalova deleted the fix/UPPSF-1181-add-runbook branch August 12, 2020 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants