Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to ft-golang-ci orb #45

Merged
merged 1 commit into from Oct 23, 2020
Merged

Migrate to ft-golang-ci orb #45

merged 1 commit into from Oct 23, 2020

Conversation

bboykov
Copy link
Contributor

@bboykov bboykov commented Oct 15, 2020

Scope and particulars of this PR (Please tick all that apply)

  • Tech hygiene (dependency updating & other tech debt)
  • Bug fix
  • Feature
  • Documentation
  • Breaking change
  • Minor change (e.g. fixing a typo, adding config)

This Pull Request follows the rules described in our Pull Requests Guide

@coveralls
Copy link

coveralls commented Oct 21, 2020 •
edited

Coverage Status

Coverage remained the same at 96.018% when pulling fcddb14 on fix/UPPSF-666-migrate-to-ft-golang-ci-orb into b2c7bf7 on master.

@ivan-p-nikolov ivan-p-nikolov force-pushed the fix/UPPSF-666-migrate-to-ft-golang-ci-orb branch 2 times, most recently from e313437 to fcddb14 Compare October 21, 2020 11:09
@ivan-p-nikolov ivan-p-nikolov requested review from a team October 21, 2020 11:10
@ivan-p-nikolov
Copy link
Contributor

Snyk scan fails because it can't get the private ft sdk repo.

@ivan-p-nikolov ivan-p-nikolov requested a review from a team October 23, 2020 09:54
@ivan-p-nikolov ivan-p-nikolov merged commit ab0f83e into master Oct 23, 2020
@ivan-p-nikolov ivan-p-nikolov deleted the fix/UPPSF-666-migrate-to-ft-golang-ci-orb branch October 23, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgi-denchew georgi-denchew georgi-denchew approved these changes

@mchompalova mchompalova mchompalova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bboykov @coveralls @ivan-p-nikolov @georgi-denchew @mchompalova