Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations with same predicate are ordered before applying primary t… #65

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

Eng3lFT
Copy link
Contributor

@Eng3lFT Eng3lFT commented Jan 9, 2023

Description

What

Orders the annotations before setting the primary theme of the Index to be sure is always the same.

Why

JIRA ticket.

Scope and particulars of this PR (Please tick all that apply)

  • Tech hygiene (dependency updating & other tech debt)
  • Bug fix
  • Feature
  • Documentation
  • Breaking change
  • Minor change (e.g. fixing a typo, adding config)

This Pull Request follows the rules described in our Pull Requests Guide

@Eng3lFT Eng3lFT requested a review from a team as a code owner January 9, 2023 14:40
@coveralls
Copy link

coveralls commented Jan 9, 2023

Coverage Status

Coverage: 93.89% (-1.4%) from 95.259% when pulling 2adf62c on fix/UPPSF-4128-consistent-primary-theme into 1c98371 on master.

pkg/mapper/mapper.go Outdated Show resolved Hide resolved
pkg/mapper/mapper.go Outdated Show resolved Hide resolved
pkg/mapper/mapper.go Outdated Show resolved Hide resolved
pkg/mapper/mapper.go Show resolved Hide resolved
@Eng3lFT Eng3lFT force-pushed the fix/UPPSF-4128-consistent-primary-theme branch from 5a0cedc to eb76fe1 Compare January 12, 2023 09:14
@Eng3lFT Eng3lFT force-pushed the fix/UPPSF-4128-consistent-primary-theme branch from eb76fe1 to 56a7d05 Compare January 12, 2023 11:16
@atanasdinov atanasdinov requested review from atanasdinov and a team January 13, 2023 07:55
pkg/mapper/mapper.go Show resolved Hide resolved
pkg/mapper/mapper.go Outdated Show resolved Hide resolved
Simplifying filtering and sorting.
@Eng3lFT Eng3lFT merged commit 8168cda into master Jan 23, 2023
@Eng3lFT Eng3lFT deleted the fix/UPPSF-4128-consistent-primary-theme branch January 23, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants