fix: address logging infinite recursion issue #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cropped up as a bug recently where Content Discovery were trying to log an entire Request object, which references itself. This resulted in Node.js running out of memory because we were infinitely recursing over the properties. This is a bug that's always been present in n-mask-logger. I've addressed the issue with my first legit use of `WeakSet` and I'm quite pleased with myself about it 馃榿
rowanmanning
force-pushed
the
handle-circular-references-in-masking
branch
from
acd024e
to
225faa4
Compare
CyntiBinti
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cropped up as a bug recently where Content Discovery were trying to log an entire Request object, which references itself. This resulted in Node.js running out of memory because we were infinitely recursing over the properties.
This is a bug that's always been present in n-mask-logger.
I've addressed the issue with my first legit use of
WeakSetand I'm quite pleased with myself about it 馃榿