Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch replace annotations #42

Merged
merged 6 commits into from
Sep 27, 2019
Merged

Batch replace annotations #42

merged 6 commits into from
Sep 27, 2019

Conversation

mchompalova
Copy link
Contributor

No description provided.

ivan-p-nikolov
ivan-p-nikolov reviewed Sep 25, 2019
View reviewed changes
handler/handler.go Outdated Show resolved Hide resolved
handler/handler.go Outdated Show resolved Hide resolved
handler/handler_test.go Outdated Show resolved Hide resolved
handler/handler_test.go Outdated Show resolved Hide resolved
handler/handler_test.go Outdated Show resolved Hide resolved
handler/handler.go Outdated Show resolved Hide resolved
handler/handler.go Show resolved Hide resolved
handler/handler.go Show resolved Hide resolved
karsov
karsov suggested changes Sep 25, 2019
View reviewed changes
handler/handler.go Show resolved Hide resolved
handler/handler.go Show resolved Hide resolved
handler/handler.go Outdated Show resolved Hide resolved
handler/handler_test.go Show resolved Hide resolved
@karsov
Copy link

karsov commented Sep 25, 2019

Also some squashing of the commits can be beneficial.

@mchompalova mchompalova force-pushed the feature/UPPSF-489-batch-replace-annotations branch from 3ea1149 to 95a578c Compare September 26, 2019 08:21
@coveralls
Copy link

coveralls commented Sep 26, 2019 •
edited

Coverage Status

Coverage increased (+0.3%) to 92.208% when pulling 8c30db6 on feature/UPPSF-489-batch-replace-annotations into afe9771 on master.

@mchompalova mchompalova force-pushed the feature/UPPSF-489-batch-replace-annotations branch from 95a578c to 8c30db6 Compare September 26, 2019 10:55
@mchompalova mchompalova merged commit 4126bc7 into master Sep 27, 2019
@mchompalova mchompalova deleted the feature/UPPSF-489-batch-replace-annotations branch September 27, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karsov karsov karsov approved these changes

@ivan-p-nikolov ivan-p-nikolov ivan-p-nikolov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mchompalova @karsov @coveralls @ivan-p-nikolov