Feature/uppsf 836 change replace endpoint #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchompalova
suggested changes
Oct 29, 2019
| newHash := randomdata.RandStringRunes(56) | ||
|
|
||
| const contentID = "83a201c6-60cd-11e7-91a7-502f7ee26895" | ||
| fromAnnotationAPI := []annotations.Annotation{ |
There was a problem hiding this comment.
You can use expectedAnnotations.Annotations for input and move the response slice outside the test to be consistent with the other tests.
There was a problem hiding this comment.
I explicitly did not reuse any of the already defined structures. I feel that keeping the data next to the code makes for more readable tests and less fragile test suite.
There was a problem hiding this comment.
I agree but if we don't reuse the structures, our code will become very large.
There was a problem hiding this comment.
To avoid the code getting too large with such structures we can use fixtures.
mchompalova
previously approved these changes
Oct 30, 2019
| newHash := randomdata.RandStringRunes(56) | ||
|
|
||
| const contentID = "83a201c6-60cd-11e7-91a7-502f7ee26895" | ||
| fromAnnotationAPI := []annotations.Annotation{ |
There was a problem hiding this comment.
To avoid the code getting too large with such structures we can use fixtures.
mchompalova
previously approved these changes
Oct 31, 2019
MiroslavGatsanoga
previously approved these changes
Oct 31, 2019
ivan-p-nikolov
dismissed stale reviews from MiroslavGatsanoga and mchompalova
via
fa39a18
ivan-p-nikolov
force-pushed
the
feature/UPPSF-836-change-replace-endpoint
branch
from
9385377
to
fa39a18
Compare
MiroslavGatsanoga
approved these changes
Oct 31, 2019
mchompalova
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable replace annotation endpoint to accept both concept id and predicate for substitution.
Add
http://www.ft.com/ontology/hasBrandas a valid predicate identifier.Update healthcheck panic guide urls.
Add documentation for replace endpoint.