Add validation for draft annotations #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManoelMilchev
approved these changes
Mar 27, 2024
annotations/annotations_api.go
Outdated
| @@ -68,13 +69,14 @@ type UPPAnnotationsAPI struct { | |||
| endpointTemplate string | |||
| username string | |||
| password string | |||
| httpClient *http.Client | |||
| httpClient *http.Client `` | |||
There was a problem hiding this comment.
question: Are the ticks "``" some kind of leftover here, or they do something I don't know ?
There was a problem hiding this comment.
It is some kind of leftover :)
handler/handler_test.go
Outdated
|
|
||
| r.Patch("/drafts/content/:uuid/annotations/:cuuid", h.ReplaceAnnotation) | ||
| r.HandleFunc("/drafts/content/{uuid}/annotations/{cuuid}", h.ReplaceAnnotation).Methods("PATCH") |
There was a problem hiding this comment.
nitpick (non-blocking): I really like to use the http constants when using the Methods functionality, it's just beautiful.
Suggested change
| r.HandleFunc("/drafts/content/{uuid}/annotations/{cuuid}", h.ReplaceAnnotation).Methods("PATCH") | |
| r.HandleFunc("/drafts/content/{uuid}/annotations/{cuuid}", h.ReplaceAnnotation).Methods(http.MethodPatch) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What
Why
JIRA Ticket UPPSF-4927
Anything, in particular, you'd like to highlight to reviewers
Mention here sections of code which you would like reviewers to pay extra attention to .E.g
Would appreciate a second pair of eyes on the test
I am not quite sure how this bit works
Is there a better library for doing x
Scope and particulars of this PR (Please tick all that apply)
DoD - Ensure all relevant tasks are completed before marking this PR as "Ready for review"
This Pull Request follows the rules described in our Pull Requests Guide