Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix limit bug #56

Merged
merged 4 commits into from
Feb 25, 2019
Merged

fix limit bug #56

merged 4 commits into from
Feb 25, 2019

Conversation

jkerr321
Copy link
Contributor

fixes #55

@jkerr321 jkerr321 requested review from a team and taktran February 25, 2019 12:33
taktran
taktran reviewed Feb 25, 2019
View reviewed changes
Copy link
Contributor

@taktran taktran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other places that should be changed for limit too

src/commands/shared.js Outdated Show resolved Hide resolved
src/commands/shared.js Outdated Show resolved Hide resolved
jkerr321 and others added 3 commits February 25, 2019 14:17
@jkerr321
update limit yargs config
f0d268c
@taktran @jkerr321
Update src/commands/shared.js
68d220d 
Co-Authored-By: jkerr321 <jennifer.kerr@ft.com>
@taktran @jkerr321
Update src/commands/shared.js
cd0e736 
Co-Authored-By: jkerr321 <jennifer.kerr@ft.com>
taktran
taktran reviewed Feb 25, 2019
View reviewed changes
src/commands/shared.js Outdated Show resolved Hide resolved
taktran
taktran approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@taktran taktran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swish! 🏀

@jkerr321 jkerr321 merged commit 6f126fc into master Feb 25, 2019
@jkerr321 jkerr321 deleted the fix-limit-bug branch February 25, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taktran taktran taktran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit is not being passed into yargs
2 participants
@jkerr321 @taktran