This repository has been archived by the owner on Jul 27, 2020. It is now read-only.
BREAKING CHANGE: search now resolves with object containing articles and... #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,8 @@ | |||
|
|
|||
|
|
|||
| function Facet(name, count){ | |||
There was a problem hiding this comment.
I'd only build a model around something that needs it - Eg, transforming the data in someway. This isn't Java :)
Sometimes elements.push({ name: 'foo', count: 123 }); might do ?
aintgoin2goa
added a commit
that referenced
this pull request
Oct 17, 2014
BREAKING CHANGE: search now resolves with object containing articles and...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... facets
This is so I can use the list of facets in search filters. Also, we may need other kinds of metadata in the future.