-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag only write on update #19
Conversation
…ord. Starting adding tests. Slight refactoring
Still lacking tests for other S3 API failures
…re written. Added a test and refactored some existing ones
service/processor.go
Outdated
rw.Write([]byte("{\"message\":\"Downstream service responded with error\"}")) | ||
return | ||
case UNCHANGED: | ||
rw.WriteHeader(http.StatusNoContent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a 304 Not Modified?
service/processor.go
Outdated
svc: svc, | ||
bucketName: bucketName, | ||
bucketPrefix: bucketPrefix, | ||
OnlyUpdatesEnabled: onlyUpdatesEnabled, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be exported? I can't see any other references to it outside the package.
service/processor_test.go
Outdated
"github.com/Financial-Times/message-queue-gonsumer/consumer" | ||
transactionid "github.com/Financial-Times/transactionid-utils-go" | ||
"github.com/aws/aws-sdk-go/aws" | ||
"github.com/aws/aws-sdk-go/aws/awserr" | ||
"github.com/aws/aws-sdk-go/service/s3" | ||
"github.com/aws/aws-sdk-go/service/s3/s3iface" | ||
hashstructure "github.com/mitchellh/hashstructure" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant alias
No description provided.