Major/uppsf 986 update kafka lib #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karsov
suggested changes
Jan 9, 2020
There was a problem hiding this comment.
Does not look like it's working properly, when I send a message to be picked by the service, I see the following in the logs:
generic-rw-s3-9595c7b98-72nmk generic-rw-s3 Failed to obtain reader, logger is not initialised - please use InitLogger or InitDefaultLogger function
main.go
Outdated
| @@ -119,6 +119,11 @@ func main() { | |||
| EnvVar: "REQUEST_LOGGING_ENABLED", | |||
| }) | |||
|
|
|||
| logConf := log.KeyNamesConfig{KeyTime: "@time"} | |||
| logger := log.NewUPPLogger(*appName, *logLevel, logConf) | |||
There was a problem hiding this comment.
*appName, *logLevel receive their values from the user input in the app.Action block.
| } | ||
|
|
||
| logger.InitLogger(*appName, *logLevel) |
There was a problem hiding this comment.
Not sure if we need to remove this. I think this is still used in the other parts of the service.
ivan-p-nikolov
force-pushed
the
major/UPPSF-986-update-kafka-lib
branch
from
01199b0
to
7ff1a4f
Compare
Apply go mod tidy Start using go-logger/v2 in main.go
ivan-p-nikolov
force-pushed
the
major/UPPSF-986-update-kafka-lib
branch
from
7ff1a4f
to
756f32a
Compare
karsov
approved these changes
Jan 14, 2020
MiroslavGatsanoga
approved these changes
Jan 15, 2020
ivan-p-nikolov
added a commit
that referenced
this pull request
Jan 16, 2020
…fka-lib Major/uppsf 986 update kafka lib
ivan-p-nikolov
added a commit
that referenced
this pull request
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump service to v2
Start using go-logger/v2 in main.go
Move to v1.0.0 of
message-queue-gosumer