Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added '/' endpoint to get all data from S3 bucket #4

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Added '/' endpoint to get all data from S3 bucket #4

merged 1 commit into from
Feb 10, 2017

Conversation

carlosroman
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.22% when pulling 59352cb1f29bdbf9f3d2c3741868434f8c530385 on Get_all_endpoint into 005789c on master.

JuliaFernee
JuliaFernee suggested changes Feb 9, 2017
View reviewed changes
Copy link
Contributor

@JuliaFernee JuliaFernee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, The CircleCI test TestReaderHandler_HandleGetAllOK is failing consistently. I've re-run it and it is still failing. At the same time the "circle ci" tags/buttons (don't know what you'd call them) configured at the top of README saying that the tests are passing, which looks incorrect as well.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.235% when pulling 86c9d8013e0a939ce9066990a95788e7a80a4f5a on Get_all_endpoint into 005789c on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.235% when pulling fe11a20603f05c599c3d4559df4a41f30ee318a9 on Get_all_endpoint into 005789c on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.235% when pulling ac7660790cb4a4c85b4a88973f6135a98522ff97 on Get_all_endpoint into 005789c on master.

@carlosroman
Added '/' endpoint to get all data from S3 bucket
b825368 
Also fixed the Ids endpoint to return Ids without prefix.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 98.529% when pulling b825368 on Get_all_endpoint into 005789c on master.

@carlosroman carlosroman merged commit 8eda0bb into master Feb 10, 2017
@carlosroman carlosroman deleted the Get_all_endpoint branch February 10, 2017 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaFernee JuliaFernee JuliaFernee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carlosroman @coveralls @JuliaFernee