Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/uppsf 4513 add external generic rw s3 #53

Merged
merged 3 commits into from Aug 29, 2023

Conversation

ManoelMilchev
Copy link
Contributor

Description

What

Add external-generic-rw-s3 which will write concepts in upp-external-concept-normalised-store-dev.

Why

JIRA

Scope and particulars of this PR (Please tick all that apply)

  • Tech hygiene (dependency updating & other tech debt)
  • Bug fix
  • Feature
  • Documentation
  • Breaking change
  • Minor change (e.g. fixing a typo, adding config)

This Pull Request follows the rules described in our Pull Requests Guide

@ManoelMilchev ManoelMilchev requested a review from a team as a code owner August 23, 2023 06:01
@asparuhft asparuhft self-requested a review August 24, 2023 08:48
asparuhft
asparuhft previously approved these changes Aug 24, 2023
Copy link

@asparuhft asparuhft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asparuhft asparuhft requested a review from a team August 24, 2023 10:47
@ManoelMilchev ManoelMilchev dismissed asparuhft’s stale review August 28, 2023 06:54

The merge-base changed after approval.

@ManoelMilchev ManoelMilchev force-pushed the feature/UPPSF-4513-add-external-generic-rw-s3 branch from a5a4e03 to 551d242 Compare August 28, 2023 07:02
Copy link

@epavlova epavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add tasks for the Stage and Prod work.

@epavlova epavlova requested a review from a team August 28, 2023 08:19
@coveralls
Copy link

Coverage Status

coverage: 93.068%. remained the same when pulling 551d242 on feature/UPPSF-4513-add-external-generic-rw-s3 into 47a7c5e on master.

@ManoelMilchev ManoelMilchev merged commit 96c4679 into master Aug 29, 2023
2 of 3 checks passed
@ManoelMilchev ManoelMilchev deleted the feature/UPPSF-4513-add-external-generic-rw-s3 branch August 29, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants