Fixing tests to include a valid ARN

Financial-Times · Apr 20, 2023 · c055fa0 · c055fa0
1 parent 1a2478f
commit c055fa0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 10 deletions.
diff --git a/consumer_test.go b/consumer_test.go
@@ -17,13 +17,18 @@ import (
 )
 
 const testConsumerGroup = "testGroup"
+const testARN = "arn:aws:kafka:eu-west-1:123456789012:cluster/testCluster/12345678-1234-1234-1234-123456789012-1"
 
 var testMessages = []*sarama.ConsumerMessage{{Value: []byte("Message1")}, {Value: []byte("Message2")}}
 
 type clusterDescriberMock struct {
 	describeCluster func(ctx context.Context, input *kafka.DescribeClusterV2Input, optFns ...func(*kafka.Options)) (*kafka.DescribeClusterV2Output, error)
 }
 
+func strAsPtr(s string) *string {
+	return &s
+}
+
 func (cd *clusterDescriberMock) DescribeClusterV2(ctx context.Context, input *kafka.DescribeClusterV2Input, optFns ...func(*kafka.Options)) (*kafka.DescribeClusterV2Output, error) {
 	if cd.describeCluster != nil {
 		return cd.describeCluster(ctx, input, optFns...)
@@ -79,7 +84,7 @@ func TestConsumer_Connectivity(t *testing.T) {
 			newConsumer: func() *Consumer {
 				return &Consumer{
 					config: ConsumerConfig{
-						ClusterArn:              new(string),
+						ClusterArn:              strAsPtr(testARN),
 						BrokersConnectionString: "unknown:9092",
 					},
 					clusterDescriber: &clusterDescriberMock{
@@ -97,7 +102,7 @@ func TestConsumer_Connectivity(t *testing.T) {
 			newConsumer: func() *Consumer {
 				return &Consumer{
 					config: ConsumerConfig{
-						ClusterArn:              new(string),
+						ClusterArn:              strAsPtr(testARN),
 						BrokersConnectionString: "unknown:9092",
 					},
 					clusterDescriber: &clusterDescriberMock{
@@ -119,7 +124,7 @@ func TestConsumer_Connectivity(t *testing.T) {
 			newConsumer: func() *Consumer {
 				return &Consumer{
 					config: ConsumerConfig{
-						ClusterArn:              new(string),
+						ClusterArn:              strAsPtr(testARN),
 						BrokersConnectionString: "unknown:9092",
 					},
 					clusterDescriber: &clusterDescriberMock{
@@ -145,7 +150,7 @@ func TestConsumer_Connectivity(t *testing.T) {
 
 				return &Consumer{
 					config: ConsumerConfig{
-						ClusterArn:              new(string),
+						ClusterArn:              strAsPtr(testARN),
 						BrokersConnectionString: broker.Addr(),
 					},
 					clusterDescriber: &clusterDescriberMock{
@@ -171,7 +176,7 @@ func TestConsumer_Connectivity(t *testing.T) {
 
 				return &Consumer{
 					config: ConsumerConfig{
-						ClusterArn:              new(string),
+						ClusterArn:              strAsPtr(testARN),
 						BrokersConnectionString: broker.Addr(),
 					},
 					clusterDescriber: &clusterDescriberMock{

diff --git a/producer_test.go b/producer_test.go
@@ -82,7 +82,7 @@ func TestProducer_Connectivity(t *testing.T) {
 			newProducer: func() *Producer {
 				return &Producer{
 					config: ProducerConfig{
-						ClusterArn:              new(string),
+						ClusterArn:              strAsPtr(testARN),
 						BrokersConnectionString: "unknown:9092",
 					},
 					clusterDescriber: &clusterDescriberMock{
@@ -100,7 +100,7 @@ func TestProducer_Connectivity(t *testing.T) {
 			newProducer: func() *Producer {
 				return &Producer{
 					config: ProducerConfig{
-						ClusterArn:              new(string),
+						ClusterArn:              strAsPtr(testARN),
 						BrokersConnectionString: "unknown:9092",
 					},
 					clusterDescriber: &clusterDescriberMock{
@@ -122,7 +122,7 @@ func TestProducer_Connectivity(t *testing.T) {
 			newProducer: func() *Producer {
 				return &Producer{
 					config: ProducerConfig{
-						ClusterArn:              new(string),
+						ClusterArn:              strAsPtr(testARN),
 						BrokersConnectionString: "unknown:9092",
 					},
 					clusterDescriber: &clusterDescriberMock{
@@ -148,7 +148,7 @@ func TestProducer_Connectivity(t *testing.T) {
 
 				return &Producer{
 					config: ProducerConfig{
-						ClusterArn:              new(string),
+						ClusterArn:              strAsPtr(testARN),
 						BrokersConnectionString: broker.Addr(),
 					},
 					clusterDescriber: &clusterDescriberMock{
@@ -174,7 +174,7 @@ func TestProducer_Connectivity(t *testing.T) {
 
 				return &Producer{
 					config: ProducerConfig{
-						ClusterArn:              new(string),
+						ClusterArn:              strAsPtr(testARN),
 						BrokersConnectionString: broker.Addr(),
 					},
 					clusterDescriber: &clusterDescriberMock{