Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to forward errors #14

Merged
merged 10 commits into from
Feb 12, 2018
Merged

Added possibility to forward errors #14

merged 10 commits into from
Feb 12, 2018

Conversation

tosan88
Copy link
Contributor

@tosan88 tosan88 commented Feb 2, 2018

Changes include:

  • An app could specify an error channel as a parameter for new consumer which would now receive the errors while consuming from kafka (also kept existing behavior as well)
  • Updated vendoring for kazoo-go lib
  • A new consumer now is created via config struct (better for extending constructor params)

NOTE: No tests for the new feature & some data race is detected by CircleCI in the underlying library

  • added tests for the new feature, refactored existing tests a bit
  • cannot reproduce the data race, tests run cleanly, both locally and on CircleCI
  • removed unused err return value from ftmessage#parseHeaders and adjusted callers

@coveralls
Copy link

coveralls commented Feb 6, 2018

Coverage Status

Coverage increased (+2.5%) to 95.273% when pulling 2a65348 on improvements into af40f10 on master.

@tosan88
Copy link
Contributor Author

tosan88 commented Feb 12, 2018

👍 for the changes by @tamas-molnar

@kovacshuni
Copy link

yeah!

@tosan88 tosan88 merged commit b8bc1f9 into master Feb 12, 2018
@tosan88 tosan88 deleted the improvements branch February 12, 2018 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants