Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added constant for lag technical summary #31

Conversation

ilian2233
Copy link
Contributor

Description

Added a constant in the consumer file for other services as a technical summary when lag is present.

What

Lag should not make a service appear unhealthy. When this constant is used in the technical summary of a health check of service that health check will be ignored even if failing.

Why

JIRA ticket

Scope and particulars of this PR (Please tick all that apply)

  • Tech hygiene (dependency updating & other tech debt)
  • Bug fix
  • Feature
  • Documentation
  • Breaking change
  • Minor change (e.g. fixing a typo, adding config)

This Pull Request follows the rules described in our Pull Requests Guide

@ilian2233 ilian2233 marked this pull request as ready for review July 5, 2022 11:49
@ilian2233 ilian2233 requested review from a team as code owners July 5, 2022 11:49
martin-stanchev
martin-stanchev previously approved these changes Jul 5, 2022
atanasdinov
atanasdinov previously approved these changes Jul 5, 2022
consumer.go Outdated Show resolved Hide resolved
@ilian2233 ilian2233 force-pushed the minor/UPPSF-3283-avoid-consumer-monitoring-reports-in-upp-aggregate-healthcheck branch from 46484ec to 21389c1 Compare July 5, 2022 14:08
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.389% when pulling 21389c1 on minor/UPPSF-3283-avoid-consumer-monitoring-reports-in-upp-aggregate-healthcheck into a3d0a26 on v3.

@ilian2233 ilian2233 merged commit 53bf900 into v3 Jul 5, 2022
@ilian2233 ilian2233 deleted the minor/UPPSF-3283-avoid-consumer-monitoring-reports-in-upp-aggregate-healthcheck branch July 5, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants