This repository has been archived by the owner on Jul 4, 2019. It is now read-only.
Consolidate api gateway urls and keys #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 19, 2017 13:12
…SE_PATH Use one config var API_MEMB_GATEWAY_KEY for requests to ALS and ACS as they are the same key. Remove empty emailNotification.js file 🐿 v2.5.16
leggsimon
approved these changes
Sep 19, 2017
| @@ -10,7 +10,7 @@ const logger = require('@financial-times/n-logger').default; | |||
| const env = require('./helpers/env'); | |||
| const expectOwnProperties = require('./helpers/expectExtensions').expectOwnProperties; | |||
| const mockAPI = env.USE_MOCK_API; | |||
| const baseUrl = `${require('./../lib/helpers/config').ACS_API_URL}/acquisition-contexts`; | |||
| const baseUrl = `${require('./../lib/helpers/config').API_GATEWAY_HOST}/acquisition-contexts`; | |||
There was a problem hiding this comment.
For the sake of consistency could we make this
const config = require('./../lib/helpers/config');
const baseUrl = `${config.API_GATEWAY_HOST}/acquisition-contexts`;| API_GATEWAY_HOST: envVars.KAT_API_GATEWAY_HOST || envVars.API_GATEWAY_HOST, | ||
| API_GATEWAY_KEY: envVars.KAT_API_GATEWAY_KEY || envVars.API_GATEWAY_KEY, | ||
| KAT_MEMB_API_KEY: envVars.KAT_MEMB_API_KEY || envVars.KAT_ALS_API_KEY || envVars.ALS_API_KEY, |
There was a problem hiding this comment.
Could we now just remove KAT_ALS_API_KEY and ALS_API_KEY completely??
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐿 v2.5.16