update node to v14

[nl-ria]

Why?

Tech Debt week

What?

• Updated rel-engage to v8
• Updated node to v14 in both circleCI's docker image and in package.json
• Added the missing PR template
• Dropped checking for compatibility of node v10 since its going End of Life in April 2021
• linting changes after running make verify

Anything in particular you'd like to highlight to reviewers?

I learnt that Dubnium and Erbium are node version codenames ! This sounds like a major release?

[nl-ria]

Hmmm.. circleci build is still failing..
ideas?

make build
internal/modules/cjs/loader.js:807
  return process.dlopen(module, path.toNamespacedPath(filename));
                 ^

Error: The module '/home/circleci/project/lambda-logger/node_modules/iltorb/build/bindings/iltorb.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 83. This version of Node.js requires
NODE_MODULE_VERSION 64. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:807:18)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/circleci/project/lambda-logger/node_modules/iltorb/index.js:10:40)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
Makefile:27: recipe for target 'build' failed
make: *** [build] Error 1

Exited with code exit status 2
CircleCI received exit code 2

I have tried to bust circleCI cache by changing the cache key, but the error is still there 🤔

[GeoffThorpeFT]

Changes looks great to me but as you say there is something going on with the dubnium checks.

[nl-ria]

I have deleted the .npmrc file , but its still being used here - can someone explain its use to me in this context please? I didnt think it was required since we are using node v14 everywhere.

[nl-ria]

I have deleted the .npmrc file , but its still being used here - can someone explain its use to me in this context please? I didnt think it was required since we are using node v14 everywhere.

Thoughts on this @i-like-robots ?