This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
Use AWS IAM role #38
Merged
Use AWS IAM role #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanasdinov
force-pushed
the
feature/CPH-282_migrate-to-iamroles
branch
from
7a83611
to
e97d102
Compare
atanasdinov
force-pushed
the
feature/CPH-282_migrate-to-iamroles
branch
2 times, most recently
from
bebd043
to
34a9ec5
Compare
atanasdinov
force-pushed
the
feature/CPH-282_migrate-to-iamroles
branch
from
34a9ec5
to
76c4300
Compare
atanasdinov
force-pushed
the
feature/CPH-282_migrate-to-iamroles
branch
from
2ab0ad8
to
9853da5
Compare
atanasdinov
force-pushed
the
feature/CPH-282_migrate-to-iamroles
branch
from
a2a8f22
to
35729a8
Compare
dbelev
approved these changes
Oct 17, 2022
ivanruski
approved these changes
Oct 17, 2022
| return err | ||
| } | ||
|
|
||
| func newPipe(op operation) (io.ReadCloser, io.WriteCloser) { |
There was a problem hiding this comment.
nitpick (non-blocking): newPipe is only used in backupService.go. We can move it there.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What
klauspost/compressto latest version improving the Snappy compressionrlmcpherson/s3gof3rtoaws/aws-sdk-gogopkg.in/mgo.v2togo.mongodb.org/mongo-driverWhy
JIRA Ticket
Anything, in particular, you'd like to highlight to reviewers
Scope and particulars of this PR (Please tick all that apply)
This Pull Request follows the rules described in our Pull Requests Guide