Skip to content

Commit

Permalink
Merge pull request #781 from Financial-Times/ACQ-2540-fix-prettier-es…
Browse files Browse the repository at this point in the history
…lint-and-lint-staged-config-in-our-repos

ACQ-2540: fix prettier, eslint and lint-staged configs
  • Loading branch information
JuanTincho committed Jan 8, 2024
2 parents c7ef851 + 299580c commit 4915572
Show file tree
Hide file tree
Showing 8 changed files with 269 additions and 471 deletions.
8 changes: 6 additions & 2 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,9 @@
/dist
/.eslintrc.js
/public
secret-squirrel.js
secret-squirrel.cjs
package-lock.json
*.json
*.sh
.*
*.feature
/docs
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module.exports = {
extends: [
"@financial-times/eslint-config-next",
"prettier",
"plugin:prettier/recommended",
"plugin:storybook/recommended"
],
rules: {
Expand Down
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ node_modules

/coverage
/pa11y-screen-capture
/docs

*.json
*.sh
Expand Down
12 changes: 9 additions & 3 deletions .toolkitrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ plugins:
- "@dotcom-tool-kit/jest"
- "@dotcom-tool-kit/eslint"
- "@dotcom-tool-kit/prettier"
- "@dotcom-tool-kit/lint-staged"
- "@dotcom-tool-kit/lint-staged-npm"
- "@dotcom-tool-kit/husky-npm"
- './toolkit/run-storybook'
- "./toolkit/run-storybook"
hooks:
test:local:
- Eslint
Expand All @@ -15,10 +15,16 @@ hooks:
- Eslint
- JestCI
run:local:
- RunStorybook
- RunStorybook
options:
"@dotcom-tool-kit/circleci":
nodeVersion: 18.17-browsers
"@dotcom-tool-kit/babel":
files: "components/{*.jsx,index.js}"
outputPath: dist
"@dotcom-tool-kit/lint-staged-npm":
testGlob: "**/*.{js,jsx,json,scss}"
formatGlob: "**/*.{js,jsx,json,scss}"
"@dotcom-tool-kit/prettier":
files: ["**/*.{js,jsx,json,scss}"]
configFile: ".prettierrc.js"
14 changes: 8 additions & 6 deletions components/accept-terms-subscription.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -95,16 +95,18 @@ export function AcceptTermsSubscription({
<ul className="o-typography-list ncf__accept-terms-list">
<li>
<span className="terms-transition terms-transition--immediate">
I give consent for the chosen payment method to be charged automatically.
I give consent for the chosen payment method to be charged
automatically.
</span>
</li>
<li>
<span className="terms-transition terms-transition--immediate">
By placing your order subject to the Terms & Conditions (save for section 2) referred to
below, you are waiving your statutory right to cancel our contract within 14 days of
payment. Your payment is a one-time payment collected at the time of checkout, and
unsubscribing or cancelling at any point (whether before or after the 14-day period)
will not entitle you to a refund.
By placing your order subject to the Terms & Conditions (save for
section 2) referred to below, you are waiving your statutory right
to cancel our contract within 14 days of payment. Your payment is
a one-time payment collected at the time of checkout, and
unsubscribing or cancelling at any point (whether before or after
the 14-day period) will not entitle you to a refund.
</span>
</li>
<li>
Expand Down
8 changes: 3 additions & 5 deletions components/confirmation.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,9 @@ export function Confirmation({
</p>
</div>
<p className="ncf__paragraph">
{
!isTermedSubscriptionTermType
? 'We will automatically renew your subscription using the payment method provided unless you cancel before your renewal date. '
: ''
}
{!isTermedSubscriptionTermType
? 'We will automatically renew your subscription using the payment method provided unless you cancel before your renewal date. '
: ''}
{'See our '}
<a
className="ncf__link ncf__link--external"
Expand Down
Loading

0 comments on commit 4915572

Please sign in to comment.