Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAT-1438: confirmation page fixes #795

Conversation

huxley-ft
Copy link
Contributor

@huxley-ft huxley-ft commented May 10, 2024

Description

An earlier change for the ft edit registration flow had inadvertently broken the main /register flow, this was due to the build and nature of scss compiling and styles overwriting.

I was also asked post launch to tweak the designs of the confirmation page of the /ft-edit-register flow so have done this here

Ticket

Screenshots

before: broken /register path
screenshot_2024-05-10_at_10 15 15_720

fixed /register
Screenshot 2024-05-10 at 11 04 08

/ tweaks to ft edit registration

Screenshot 2024-05-10 at 11 03 55

Reminder

  • Documentation updated or created
  • Tests written for new or updated for existing functionality
  • Stories updated to use this change
  • Accessibility checked for screen readers and contrast
  • Design Review ran past the designer
  • Product Review ran past the product owner

@huxley-ft huxley-ft marked this pull request as ready for review May 10, 2024 10:16
@huxley-ft huxley-ft requested a review from a team as a code owner May 10, 2024 10:16
@huxley-ft huxley-ft requested a review from JuanTincho May 10, 2024 10:16
@JuanTincho JuanTincho requested a review from a team May 10, 2024 10:22
@huxley-ft huxley-ft changed the title fix + style: correct styling for registration page and add styling tweaks for ft edit registration flow fix + style: correct styling for confirmation page of the /register route and add styling tweaks for confirmation page of the /ft-edit-registration route May 13, 2024
@huxley-ft huxley-ft merged commit 4907e0b into main May 13, 2024
8 checks passed
@huxley-ft huxley-ft deleted the LAT-1438-confirmation-page-tweak-wording-add-link-to-edit-content-part-2 branch May 13, 2024 09:14
@JuanTincho JuanTincho changed the title fix + style: correct styling for confirmation page of the /register route and add styling tweaks for confirmation page of the /ft-edit-registration route LAT-1438: confirmation page fixes May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants