NOPS-1098 - Add ids and region to health checks #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heimdall doesn't show custom metrics without id. Add ids to health configurations, region wise.
|
|
||
| return nHealth.runCheck({ | ||
| id: 'error-rate', | ||
| name: `Error rate: greater than ${threshold}% of requests for ${appName}`, | ||
| id: `error-rate-${region}`, |
There was a problem hiding this comment.
does line 23 mean that this will be error-rate-_EU?
There was a problem hiding this comment.
😮 I didn't realise that, thank you to catch it!
jenniferemshepherd
approved these changes
Nov 16, 2021
apaleslimghost
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heimdall doesn't show custom metrics without id.
Add ids to health configurations, region wise.