Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter fixes and eslint configuration to ignore public folder #131

Merged
merged 2 commits into from Dec 13, 2023

Conversation

emortong
Copy link
Contributor

While trying to open another PR I got a lot of lint errors, to make the review of the other PR I separated those fixes into this PR and added the option to the toolkit/eslint plugin to ignore the /public folder.

i have tested the linter and it still lints the "**/*.js" files, while ignoring the /public folder

@emortong emortong requested a review from a team as a code owner December 12, 2023 15:45
Copy link
Contributor

@jamesr101 jamesr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emortong emortong merged commit ab0c41c into main Dec 13, 2023
8 checks passed
@emortong emortong deleted the linting-fixes branch December 13, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants