ACC-2850 only display if cookie consented #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
| @@ -176,62 +176,65 @@ module.exports.init = (appInfo = {}) => { | |||
| } = setAppInfoDefault(appInfo); | |||
| let surveyData; | |||
| let feedbackOverlay; | |||
|
|
|||
| const cookieConsent = document.cookie.includes('FTCookieConsentGDPR=true') | |||
There was a problem hiding this comment.
Question: Have we checked with the Ads & Privacy team to ensure that this is the correct way to check cookie consent?
There was a problem hiding this comment.
@GlynnPhillips I did it this way based on how other teams were checking for this cookie, but I can ask them to make sure
There was a problem hiding this comment.
Sounds reasonable then :) Thanks, just wanted to check because I know we spoke about a solution like this but I wasn't sure if my suggestions were good one :)
There was a problem hiding this comment.
Happy for you to go ahead
GlynnPhillips
previously approved these changes
Dec 18, 2023
GlynnPhillips
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
We have been informed that the Compliance team said that we need to stop the display of this mechanism for those who do not opt in to cookies.
This PR only displays the feedback form if
FTCookieConsentGDPR=true