Skip to content

Commit

Permalink
Add Node.js 20 support
Browse files Browse the repository at this point in the history
  • Loading branch information
rowanmanning committed Jan 12, 2024
1 parent 4ec4309 commit 336fb42
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 5 deletions.
11 changes: 9 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ orbs:
tool-kit: financial-times/dotcom-tool-kit@4
executors:
node:
docker:
- image: cimg/node:20.11
node18_19:
docker:
- image: cimg/node:18.19
node16_20:
Expand Down Expand Up @@ -34,8 +37,6 @@ workflows:
filters:
branches:
only: /(^renovate-.*|^nori/.*)/
tags:
only: /^v\d+\.\d+\.\d+(-.+)?/
- tool-kit/setup:
name: tool-kit/setup-<< matrix.executor >>
requires:
Expand All @@ -45,6 +46,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
filters:
tags:
Expand All @@ -57,6 +59,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
filters:
tags:
Expand All @@ -69,6 +72,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
filters:
tags:
Expand Down Expand Up @@ -103,6 +107,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
- tool-kit/build:
name: tool-kit/build-<< matrix.executor >>
Expand All @@ -112,6 +117,7 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
- tool-kit/test:
name: tool-kit/test-<< matrix.executor >>
Expand All @@ -121,4 +127,5 @@ workflows:
parameters:
executor:
- node
- node18_19
- node16_20
1 change: 1 addition & 0 deletions .toolkitrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,6 @@ hooks:
options:
'@dotcom-tool-kit/circleci':
nodeVersion:
- '20.11'
- '18.19'
- '16.20'
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"start": "dotcom-tool-kit run:local"
},
"engines": {
"node": "16.x || 18.x",
"npm": "7.x || 8.x || 9.x"
"node": "16.x || 18.x || 20.x",
"npm": "7.x || 8.x || 9.x || 10.x"
},
"repository": {
"type": "git",
Expand Down Expand Up @@ -56,6 +56,6 @@
"**/*.js": "dotcom-tool-kit format:staged test:staged --"
},
"volta": {
"node": "18.16.0"
"node": "20.11.0"
}
}

0 comments on commit 336fb42

Please sign in to comment.