NOPS-488 fully remove pingdom check #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmuller
approved these changes
Feb 10, 2023
apaleslimghost
force-pushed
the
actually-remove-pingdom
branch
from
65b6af0
to
483efef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the Pingdom check was effectively removed in #135, but in a slightly safer way than deleting it wholesale to give people a grace period to migrate in. this pr deletes all remaining vestiges of it
this should be merged after a couple of weeks, to give enough people time to update to v5 first and migrate their Pingdom checks to the proper way of doing it, then released as v6.