NOPS-817- Handle Sample and Baseline null values. #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leannecornish-ft
approved these changes
May 12, 2021
README.md
Outdated
| @@ -126,7 +126,8 @@ Checks if the value of a graphite metric has received data recently. | |||
| #### `cloudWatchThreshold` | |||
| Checks whether the value of a CloudWatch metric has crossed a threshold | |||
|
|
|||
| _Note: this assumes that `AWS_ACCESS_KEY` & `AWS_SECRET_ACCESS_KEY` are implictly available as environment variables on process.env_ | |||
| _Note: this assumes that `AWS_ACCESS_KEY` & `AWS_SECRET_ACCESS_KEY` are implicitly main | |||
There was a problem hiding this comment.
question: what does 'main' mean in this context?
There was a problem hiding this comment.
Another typo, fixed thanks
jenniferemshepherd
approved these changes
May 12, 2021
JSRedondo
pushed a commit
that referenced
this pull request
Jun 20, 2022
…hite-null-values NOPS-817- Handle Sample and Baseline null values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered that there is a situation where we get null values for Sample and Baseline from Graphite, which we aren't handling here. If Sample and Baseline are both nulls, these conditions will be false, and
okwill also be false. This PR adds transformNull to the graphite query and an additional check for null values. See discussion.Tickets
https://financialtimes.atlassian.net/browse/NOPS-817