Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTDCS-152 - Fix CircleCI configuration file #185

Merged
merged 1 commit into from
May 26, 2022
Merged

Conversation

JSRedondo
Copy link
Contributor

Add the caret to the npm version to fix a common problem in the build.

@JSRedondo JSRedondo requested a review from a team as a code owner May 26, 2022 08:53
@JSRedondo JSRedondo requested a review from a team May 26, 2022 08:54
Copy link
Member

@rowanmanning rowanmanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juanSanchezAlcala
Copy link

juanSanchezAlcala commented May 26, 2022

I had some troubles with that line too because it was detecting version 7 when it wasn't installed this happened with version 6.4.17 of npm or something similiar. The way that circleCi test this is with this lines

if npm -v | grep "$NPM_ORB_VERSION" > /dev/null 2>&1; then
echo "Success! NPM $(npm -v) has been installed to $(which npm)"
else
echo "Something went wrong; the specified version of NPM could not be installed"
exit 1
fi```
As you can se the grep is going to detect version 7 always when you have a this number inside the version.
So maybe with that line is not going to detect if you already have version 7 and always is going to try to install it . In my case i wrote in that line 7.24

@JSRedondo JSRedondo merged commit f7d5c55 into main May 26, 2022
@JSRedondo JSRedondo deleted the fix-circleci-config branch May 26, 2022 10:21
JSRedondo added a commit that referenced this pull request Jun 20, 2022
FTDCS-152 - Fix CircleCI configuration file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants