FTDCS-196 - Added default panic guide for Fastly key expiration check #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmuller
reviewed
Jun 22, 2022
| @@ -14,6 +15,7 @@ class FastlyKeyExpirationCheck extends Check { | |||
| constructor(options) { | |||
| super(options); | |||
| this.fastlyKey = options.fastlyKey; | |||
| this.panicGuide options.panicGuide || defaultPanicGuide; | |||
There was a problem hiding this comment.
I think just missing an equals here: this.panicGuide =
There was a problem hiding this comment.
Yep, I realized last moments of the work shift I was faster than lucid 🤣
alexmuller
reviewed
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The panic guide is the same for any fastly key, so there is no point to repeat the same in each configuration health check.
Anyway, there is the option to set a custom panic guide, just in case.