Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up ESLint #226

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Set up ESLint #226

merged 5 commits into from
Jan 17, 2024

Conversation

rowanmanning
Copy link
Member

@rowanmanning rowanmanning commented Jan 12, 2024

Not too many issues in the end. Each issue fixed is a separate commit if that makes this easier to review.

CPREL-945

These are mostly whitespace and semi-colons. I fixed them by running

```
eslint . --fix
```
These aren't ideal fixes because ideally these would always return a
string, but it at least makes our decision to return nothing explicit.
@rowanmanning rowanmanning requested a review from a team as a code owner January 12, 2024 16:34
@rowanmanning rowanmanning merged commit 8885436 into main Jan 17, 2024
14 checks passed
@rowanmanning rowanmanning deleted the eslint branch January 17, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants