Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitely add dist folder to publish #133

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Explicitely add dist folder to publish #133

merged 1 commit into from
Sep 13, 2023

Conversation

sami-ft
Copy link
Contributor

@sami-ft sami-ft commented Sep 12, 2023 •
edited
Loading

Entries in .gitignore files are ignored by npm by default, you have to explicitely set them for npm to not ignore them

changes:

  • explicitely set the files to be published in the files entry of the package.json

@sami-ft sami-ft requested a review from a team as a code owner September 12, 2023 15:22
oliverturner
oliverturner approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@oliverturner oliverturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had completely forgotten about this side-effect from .gitignore entries!

Elegantly fixed👌

@sami-ft sami-ft merged commit 8a59f2b into main Sep 13, 2023
11 checks passed
@sami-ft sami-ft deleted the fix_production_build branch September 13, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverturner oliverturner oliverturner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sami-ft @oliverturner