Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADSDEV 1779: Remove Node 16 reference #144

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

oliverturner
Copy link
Contributor

@oliverturner oliverturner commented Mar 14, 2024

Description

This PR addresses the Cyber Essentials requirement to remove the reference to Node 16 from package.json

@oliverturner oliverturner requested a review from a team as a code owner March 14, 2024 15:27
@oliverturner oliverturner changed the title ADSDEV 1779/remove node16 reference ADSDEV 1779: Remove Node 16 reference Mar 14, 2024
@oliverturner oliverturner force-pushed the ADSDEV-1779/remove-node16-reference branch from a09f50e to 7f6c2b7 Compare March 15, 2024 10:19
@oliverturner oliverturner force-pushed the ADSDEV-1779/remove-node16-reference branch from a197199 to c4d7db7 Compare March 15, 2024 15:34
Copy link
Contributor

@andrewgeorgiou1981 andrewgeorgiou1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work on fixing up types. I havent run the build locally but the changes look good and make sense,, so happy to approve.

@oliverturner oliverturner merged commit 1d0d0c1 into main Mar 15, 2024
8 checks passed
@oliverturner oliverturner deleted the ADSDEV-1779/remove-node16-reference branch March 15, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants