ACQ-1007: customize consent lite component for in article sign-in feature #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd hide the footer for consent lite component
angelaFT
approved these changes
Jun 21, 2021
ststdimov
approved these changes
Jun 21, 2021
ludrob
reviewed
Jun 21, 2021
| @@ -87,6 +103,7 @@ const ConsentLite = ({ | |||
| isSubsection, | |||
| formOfWords, | |||
| showSubmitButton, | |||
| hideFooter, | |||
There was a problem hiding this comment.
Question: I'm not sure what is best, I think we usually favour the showSomething flag rather than hide, it seems more intuitive...
But there is nothing wrong with this.
Also more consistent with showSubmitButton?
Suggested change
| hideFooter, | |
| showFooter = true, |
There was a problem hiding this comment.
agree, changed! 2b28e6f
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to customize terms and conditions message and hide the footer for consent lite component.
This is aim to cover some requirements needed for this ticket https://financialtimes.atlassian.net/browse/ACQ-972