Replace ft.yml with CODEOWNERS file #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes:
-- update package.json: `/Users/keran.braich/Sites/transformation-runner/repositories/n-search-parser/package.json`
-- devDependencies.n-gage:
-- Updated `@financial-times/n-gage` dependency. Previous value: ^2.0.2
-- update ft.yml:
-- CODEOWNERS file created. Owner: matt.hinchliffe@ft.com
-- ft.yml file successfully deleted.
-- update CircleCI config file: `/Users/keran.braich/Sites/transformation-runner/repositories/n-search-parser/.circleci/config.yml`
-- Updated and added to the git index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our custom
ft.ymlfile with GitHub's standard CODEOWNERS file. The CODEOWNERS file defines the individual or team that is responsible for the code in the repository. Unlikeft.yml, code owners will automatically be asked to review any pull requests.For more information on CODEOWNERS, see https://help.github.com/en/articles/about-code-owners.
Where a repository contains an empty
ft.yml, no CODEOWNERS file will be created. We did this so we can easily identify which repositories are unowned by looking for the absence of a CODEOWNERS file.The n-gage package insists that repositories have an ft.yml file. Version 3.4.0 of n-gage removes this requirement. This transformation requires n-gage version 3.4.0 in package.json because it deletes the (otherwise required) ft.yml file.