Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Commit

Permalink
Fix up component initializer logic
Browse files Browse the repository at this point in the history
 🐿 v2.5.16
  • Loading branch information
remybach committed Aug 18, 2017
1 parent a8350c1 commit 003ead4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@
"o-expander": "^4.2.2",
"next-session-client": "^2.3.1",
"n-counter-ad-blocking": "^3.1.1",
"n-desktop-app-banner": "^1.0.0"
"n-desktop-app-banner": "^1.0.1"
}
}
10 changes: 4 additions & 6 deletions browser/js/component-initializer.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import footer from '../../components/n-ui/footer';
import offlineToast from '../../components/n-ui/offline-toast';
import { lazyLoad as lazyLoadImages } from 'n-image';
import * as serviceWorker from 'n-service-worker';
import DesktopAppBanner from 'n-desktop-app-banner';
import * as syndication from 'n-syndication';
import DesktopAppBanner from '@financial-times/n-desktop-app-banner';

export const presets = {
discrete: {
Expand Down Expand Up @@ -111,11 +111,9 @@ export class ComponentInitializer {
this.initializedFeatures.lazyLoadImages = true;
}

// TODO: Figure out the way to do this correctly.
// if (!config.features.disableDesktopAppBanner) {
// new DesktopAppBanner();
// }

if (flags.get('subscriberCohort') && !flags.get('disableDesktopAppBanner')) {
new DesktopAppBanner();
}

allStylesLoaded
.then(() => {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"uglifyjs": "^2.4.11"
},
"dependencies": {
"@financial-times/n-desktop-app-banner": "^1.0.0",
"@financial-times/n-desktop-app-banner": "^1.0.1",
"@financial-times/n-express": "^19.2.3",
"@financial-times/n-handlebars": "^1.17.9",
"@financial-times/next-json-ld": "^0.2.1",
Expand Down

0 comments on commit 003ead4

Please sign in to comment.