Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Commit

Permalink
Remove adsDisableMetricsSampling flag 🐿 v2.12.5 (#1531)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexflorisca committed Jan 13, 2020
1 parent 0fd6d2e commit af23728
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .pa11yci.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ const config = {
defaults: {
timeout: 10000,
headers: {
Cookie: 'next-flags=ads:off,sourcepoint:off;secure=true'
Cookie: 'next-flags=ads:off,sourcepoint:off,secure=true,enableGTM:off'
}
},
urls: [
Expand Down
2 changes: 1 addition & 1 deletion components/n-ui/ads/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ window.oAds = Ads;
function initOAds (flags, appName, adOptions) {
const initObj = oAdsConfig(flags, appName, adOptions);

setupAdsMetrics(flags && flags.adsDisableMetricsSampling);
setupAdsMetrics(true);

utils.log('dfp_targeting', initObj.dfp_targeting);

Expand Down
3 changes: 1 addition & 2 deletions components/n-ui/ads/test/index.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,7 @@ describe('Main', () => {

it('Should setup ads monitoring functionality', () => {
const flags = {
get: () => true,
adsDisableMetricsSampling: true
get: () => true
};
const setupMetricsStub = sandbox.stub(AdsMetrics, 'setupAdsMetrics');

Expand Down

0 comments on commit af23728

Please sign in to comment.