Combines __disableAndroidBanner and __disableIosSmartBanner into one …

…variable __disableMobilePhoneBanner 🐿 v2.8.0
Financial-Times · May 8, 2018 · e5863bf · e5863bf
1 parent 18c800f
commit e5863bf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/browser/layout/wrapper.html b/browser/layout/wrapper.html
@@ -41,10 +41,10 @@
 		<link rel="icon" type="image/png" href="https://www.ft.com/__origami/service/image/v2/images/raw/ftlogo-v1%3Abrand-ft-logo-square-coloured?source=update-logos&width=194&height=194&format=png" sizes="194x194">
 		<link rel="apple-touch-icon" sizes="180x180" href="https://www.ft.com/__origami/service/image/v2/images/raw/ftlogo-v1%3Abrand-ft-logo-square-coloured?source=update-logos&width=180&height=180&format=png">
 
-		{{#unless __disableIosSmartBanner}}
+		{{#unless __disableMobilePhoneBanner}}
 		<meta name="apple-itunes-app" content="app-id=1200842933, affiliate-data=ct=smart-banner&pt=246269, app-argument={{#if canonicalUrl}}{{canonicalUrl}}{{else}}https://www.ft.com{{/if}}">
 		{{/unless}}
-		{{#if __disableAndroidBanner}}
+		{{#if __disableMobilePhoneBanner}}
 		<script>
 			// Don't show the Android install banner
 			window.addEventListener('beforeinstallprompt', function (ev) { ev.preventDefault(); return false; });

diff --git a/server/index.js b/server/index.js
@@ -73,8 +73,7 @@ module.exports = options => {
 
 	// set whether or not to disable the app install banner.
 	app.use(function (req, res, next) {
-		app.locals.__disableAndroidBanner = !res.locals.flags.subscriberCohort;
-		app.locals.__disableIosSmartBanner = !res.locals.flags.subscriberCohort;
+		app.locals.__disableMobilePhoneBanner = !res.locals.flags.subscriberCohort;
 		next();
 	});