Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Commit

Permalink
Remove welcome banner/compact view promo entirely
Browse files Browse the repository at this point in the history
  • Loading branch information
i-like-robots committed Apr 7, 2017
1 parent 8fac946 commit f637e07
Show file tree
Hide file tree
Showing 14 changed files with 2 additions and 432 deletions.
3 changes: 1 addition & 2 deletions .pa11yci.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ const config = {

const components = [
'components/n-ui/header',
'components/n-ui/footer',
'components/n-ui/compact-view-promo'
'components/n-ui/footer'
]

const cloneData = (data) => JSON.parse(JSON.stringify(data));
Expand Down
6 changes: 0 additions & 6 deletions browser/bootstrap/js/component-initializer.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import tracking from '../../../components/n-ui/tracking';
import date from 'o-date';
import header from '../../../components/n-ui/header';
import oCookieMessage from 'o-cookie-message';
import compactViewPromo from '../../../components/n-ui/compact-view-promo';
import subscriptionOfferPrompt from '../../../components/n-ui/subscription-offer-prompt';
import footer from '../../../components/n-ui/footer';
import offlineToast from '../../../components/n-ui/offline-toast';
Expand Down Expand Up @@ -122,11 +121,6 @@ export class ComponentInitializer {
this.initializedFeatures.cookieMessage = true;
}

if (config.features.compactViewPromo && !this.initializedFeatures.compactViewPromo) {
(flags.get('compactView')) && compactViewPromo.init();
this.initializedFeatures.compactViewPromo = true;
}

if (config.features.subscriptionOfferPrompt && !this.initializedFeatures.subscriptionOfferPrompt) {
subscriptionOfferPrompt(flags);
this.initializedFeatures.subscriptionOfferPrompt = true;
Expand Down
3 changes: 0 additions & 3 deletions browser/layout/wrapper.html
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,6 @@

<div class="n-layout__row n-layout__row--footer">
{{#outputBlock 'footer'}}{{/outputBlock}}
{{#if welcomeBanner}}
{{>n-ui/compact-view-promo/template}}
{{/if}}
{{>n-ui/footer/template}}
{{#if @root.flags.fancyDrawer}}
{{#unlessEquals nUi.header.variant 'logo-only'}}
Expand Down
15 changes: 0 additions & 15 deletions components/n-ui/compact-view-promo/README.md

This file was deleted.

33 changes: 0 additions & 33 deletions components/n-ui/compact-view-promo/banner.html

This file was deleted.

50 changes: 0 additions & 50 deletions components/n-ui/compact-view-promo/index.js

This file was deleted.

175 changes: 0 additions & 175 deletions components/n-ui/compact-view-promo/main.scss

This file was deleted.

21 changes: 0 additions & 21 deletions components/n-ui/compact-view-promo/pa11y-config.js

This file was deleted.

22 changes: 0 additions & 22 deletions components/n-ui/compact-view-promo/template.html

This file was deleted.

2 changes: 1 addition & 1 deletion demo/client/main.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {bootstrap} from '../../main';
const tracking = require('../../components/n-ui/tracking');

bootstrap({preset: 'complete', compactViewPromo: true}, () => {
bootstrap({ preset: 'complete' }, () => {
tracking.scrollDepth.init('n-ui-test');
});
1 change: 0 additions & 1 deletion main.scss
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,4 @@ $n-ui-foundations-applied: true;

$o-cookie-message-is-silent: false;
@import 'o-cookie-message/main';
@import 'components/n-ui/compact-view-promo/main';
@import 'components/n-ui/subscription-offer-prompt/main';
3 changes: 0 additions & 3 deletions server/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const fs = require('fs');
const navigation = require('./models/navigation/');
const EditionsModel = require('./models/navigation/editionsModel');
const anon = require('./models/anon');
const welcomeBannerModelFactory = require('./models/welcome-banner');

// templating and assets
const handlebars = require('./lib/handlebars');
Expand Down Expand Up @@ -85,8 +84,6 @@ module.exports = options => {
app.use(anon.middleware);
}

app.use(welcomeBannerModelFactory);

// Handle the akamai -> fastly -> akamai etc. circular redirect bug
app.use(function (req, res, next) {
res.locals.forceOptInDevice = req.get('FT-Force-Opt-In-Device') === 'true';
Expand Down
Loading

0 comments on commit f637e07

Please sign in to comment.