This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Specify a product value other than 'next' for spoor #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…poor. Defaults to sending 'next' as the value.
|
FYI @leggsimon @wheresrhys backwards compatible with our current way of working in next and won't add any extra markup, except for KAT and anything else that specifies a product. But please shout if something's off. |
lc512k
approved these changes
Jul 25, 2017
|
where does this get passed to spoor? |
wheresrhys
approved these changes
Jul 27, 2017
|
@wheresrhys It's passed in via the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to allow us to specify a different
productvalue to send to spoor. Defaults to sending 'next' as the value.