This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Ads - specifying ad loading viewport margins for different screensizes/page types #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adgad
reviewed
Sep 27, 2017
components/n-ui/ads/js/oAdsConfig.js
Outdated
| return '0%'; | ||
| function setViewportMarginBy () { | ||
| let pt = appName; | ||
| pt = pt.toLowerCase().substr(0, 3); |
There was a problem hiding this comment.
Is it necessary to substring it here? Might be more readable later on to refer to 'front-page' (or whatever the full name is)
components/n-ui/ads/js/oAdsConfig.js
Outdated
| if (pt === 'fro') { | ||
| if (scrnSize < 760) {return '15%';} | ||
| else { | ||
| if (pt === 'fro' && scrnSize < 980) {return '5%';} |
There was a problem hiding this comment.
checking 'fro' again here shouldn't be necessary
| sandbox.restore(); | ||
| }); | ||
| it('Should pass 15% when screen size is narrower than 760px and adOptimizeLazyLoad flag is defined and appName is fro', () => { | ||
| sandbox.stub(utils, 'getScreenSize', () => { return 750; }); |
There was a problem hiding this comment.
We should probably remove the flag from the tests...it's a little confusing otherwise
There was a problem hiding this comment.
i was planning to keep the flag but update it so that its no longer an MVT - this would allow us to toggle the viewport margin. However, i guess it doesnt give us much benefit so, as you say it might be less confusing to remove it.
adgad
approved these changes
Sep 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adgad @fenglish @alexflorisca