This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
feat: notify the Change API on deployments #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from
Makefile
Outdated
| @@ -133,6 +133,7 @@ deploy-s3: | |||
| nht deploy-hashed-assets --directory public/n-ui --monitor-assets | |||
|
|
|||
| deploy: deploy-s3 npm-publish rebuild-user-facing-apps | |||
| @$(MAKE) change-api | |||
There was a problem hiding this comment.
is there a particular reason to do it this way instead of as another dependency of deploy (i.e. after rebuild-user-facing-apps?)
There was a problem hiding this comment.
None! Hadn't thought about using it as a target dependency. Will update it to that.
sjparkinson
force-pushed
the
sjparkinson-patch-1
branch
from
0e0f858
to
053dad9
Compare
apaleslimghost
approved these changes
Jul 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo has a custom deployment target defined in it's
Makefile, so we must explicitly call thechange-apitarget that is defined in n-gage.