Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

End 'rename companies to business' experiment #1518

Merged
merged 2 commits into from
Dec 4, 2019
Merged

End 'rename companies to business' experiment #1518

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
872462c
Revert "Robust in the face of tests"
robsquires Dec 3, 2019
5c79603
Revert "rename "Companies" in menu to "Business"."
robsquires Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions server/models/navigation/navigationModelV2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,22 +16,6 @@ const menuNameMap = new Map([

const clone = obj => JSON.parse(JSON.stringify(obj));

// Function to support the A/B test of renaming the "Companies" section to "Business"
// This function can be removed once the test is complete.
function renameCompaniesToBusiness ( obj ) {
if( Array.isArray(obj) ) {
obj.forEach(renameCompaniesToBusiness);
} else if( obj ) {
if( obj.label ) {
obj.label = obj.label.replace(/^Companies/, 'Business');
}
renameCompaniesToBusiness(obj.items);
renameCompaniesToBusiness(obj.data);
renameCompaniesToBusiness(obj.submenu);
renameCompaniesToBusiness(obj.meganav);
}
}

module.exports = class NavigationModelV2 {

constructor (options){
Expand Down Expand Up @@ -132,10 +116,6 @@ module.exports = class NavigationModelV2 {
NavigationModelV2.decorateSelected(menuData, currentUrl);
}

if( res.locals.flags && res.locals.flags.renameCompaniesToBusiness ) {
renameCompaniesToBusiness(menuData);
}

res.locals.navigation.menus[menuName] = menuData;
}

Expand All @@ -153,9 +133,6 @@ module.exports = class NavigationModelV2 {
.then(data => {
// We need to add the appropriate labels to this when rendered, so mark it as selected.
const currentItem = { ...data.item, selected: true };
if( res.locals.flags && res.locals.flags.renameCompaniesToBusiness ) {
renameCompaniesToBusiness(currentItem);
}
res.locals.navigation.showSubNav = true;
res.locals.navigation.hierarchy = data;
res.locals.navigation.breadcrumb = data.ancestors.concat(currentItem);
Expand Down