Skip to content
This repository has been archived by the owner on Dec 12, 2017. It is now read-only.

Linting #55

Merged
merged 1 commit into from
Feb 15, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
'use strict';

const VerifyBuild = require('./lib/addons/verify-build');
const variants = require('./lib/variants');
const clone = require('clone');
Expand Down
2 changes: 1 addition & 1 deletion lib/addons/ie8-sass-options.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module.exports = function(source) {
module.exports = function (source) {
return `$o-grid-ie8-rules: 'only';
$o-grid-mode: 'fixed';
$o-grid-fixed-layout: 'XL';
Expand Down
3 changes: 1 addition & 2 deletions lib/addons/verify-build.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
'use strict';
const fs = require('fs');
const join = require('path').join;
const gitignore = fs.readFileSync(join(process.cwd(), '.gitignore'), 'utf8')
Expand Down Expand Up @@ -49,7 +48,7 @@ function VerifyBuild () {
// don't throw as when there are multiple webpack builds this will give false positives
// next-express will catch it in prod before starting the app anyway
// TODO - consider removing this step entirely
console.warn(`${e} is in your .gitignore but has not been built - is the build broken, or do you need to remove a line from .gitignore?`);
console.warn(`${e} is in your .gitignore but has not been built - is the build broken, or do you need to remove a line from .gitignore?`); // eslint-disable-line no-console
}

try {
Expand Down
5 changes: 3 additions & 2 deletions lib/variants.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ module.exports = function constructVariants (nWebpackOptions, variantOptions) {
}))

if (process.env.NEXT_APP_SHELL === 'local') {
console.warn(`
const nWebpackWarning = `
/*********** n-webpack warning ************/

You have set the environment variable NEXT_APP_SHELL=local
Expand All @@ -58,7 +58,8 @@ If you do not need this behaviour run
unset NEXT_APP_SHELL

/*********** n-webpack warning ************/
`)
`;
console.warn(nWebpackWarning); // eslint-disable-line no-console

const ignoresNUi = fs.readFileSync(join(process.cwd(), '.gitignore'), 'utf8')
.split('\n')
Expand Down