Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove graphite threshold check #223

Merged
merged 2 commits into from
May 20, 2024
Merged

feat!: remove graphite threshold check #223

merged 2 commits into from
May 20, 2024

Conversation

frshwtr
Copy link
Contributor

@frshwtr frshwtr commented May 20, 2024

  • Removes graphite-threshold check.

@frshwtr frshwtr requested a review from a team as a code owner May 20, 2024 09:45
@frshwtr frshwtr added the breaking Will require a major version bump label May 20, 2024
@origamiserviceuser origamiserviceuser added this to Backlog in Origami ✨ May 20, 2024
@github-actions github-actions bot added the library Relates to an Origami library label May 20, 2024
@notlee
Copy link
Contributor

notlee commented May 20, 2024 •
edited
Loading

Code looks good (aside the failing test) 😄 Don't forget the MIGRATION.md though! We can take heavy inspiration from Rowan's blog post here, as steps are similar for n-health and n-express:
https://financialtimes.atlassian.net/wiki/spaces/DS/pages/8408989698/Migrating+an+app+away+from+Graphite-based+health+checks

@frshwtr frshwtr force-pushed the feat/remove-graphite-threshold-check branch 3 times, most recently from 15271e3 to 0c6acd4 Compare May 20, 2024 10:38
@frshwtr frshwtr force-pushed the feat/remove-graphite-threshold-check branch from 0c6acd4 to 8099fb9 Compare May 20, 2024 10:41
@frshwtr frshwtr merged commit b6ac96d into master May 20, 2024
18 checks passed
Origami ✨ automation moved this from Backlog to Done May 20, 2024
@frshwtr frshwtr deleted the feat/remove-graphite-threshold-check branch May 20, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notlee notlee notlee approved these changes

Assignees
No one assigned
Labels
breaking Will require a major version bump library Relates to an Origami library
Projects
Origami ✨
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frshwtr @notlee