This repository has been archived by the owner on Nov 18, 2021. It is now read-only.
Fix external links focus outline not showing #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that when a user tabs to the link in the footer they know where they are by showing a focus outline. https://www.w3.org/WAI/WCAG21/Understanding/focus-visible.html The external link contains an override to the overflow. So needs to be after the regular matrix mixin. Jira: CPP-115 DAC ID: DAC_Missing_Visible_Focus_Indicator_Issue1
|
I think there could be some improvements to the footer BEM here, since maybe they shouldnt be sharing styles in the first place but hopefully this reflects reverting to a previous behaviour... |
NickColley
commented
Jun 12, 2020
| .o-footer__external-link { | ||
| position: relative; | ||
| border-top: 1px solid; | ||
| border-bottom: 1px solid; | ||
| // Ensure focus outline is visible. | ||
| overflow: visible; |
There was a problem hiding this comment.
This overflow: visible property was not applied since when styles were refactored into mixins they were re-ordered giving the .o-footer__external-link class a lower specificity
JakeChampion
approved these changes
Jun 12, 2020
JakeChampion
added
the
release:patch
|
🙌 Thank you again @NickColley 🎉 |
|
🎉 This PR is included in version v7.0.10 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that when a user tabs to the link in the footer they know where they are by showing a focus outline.
https://www.w3.org/WAI/WCAG21/Understanding/focus-visible.html
The external link contains an override to the overflow. So needs to be after the regular matrix mixin.
Jira: CPP-115
DAC ID: DAC_Missing_Visible_Focus_Indicator_Issue1